-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[14.0][ADD] helpdesk_mgmt_timesheet: add optional ticket field in view #477
[14.0][ADD] helpdesk_mgmt_timesheet: add optional ticket field in view #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
@@ -261,4 +261,14 @@ | |||
</field> | |||
</field> | |||
</record> | |||
<record id="view_task_form2_inherited" model="ir.ui.view"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view should be placed in its own project.task
xml file.
Also, not tested and not sure, this could lead to security issues, when user is not allowed to Helpdesk app. Could you check?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checking!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the following changes:
- moved the view to another xml file related with project.task.
- added a group restriction to helpdesk user so that only users in that group can view the field.
@dalonsod
8fc0fbd
to
88da8c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR has the |
@pedrobaeza good to merge? |
88da8c6
to
fa5010a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ocabot merge minor
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 100f6ca. Thanks a lot for contributing to OCA. ❤️ |
This adds an optional ticket field in Project Task timesheets tree view.